Use ifalias for Planned Maintenance "str" and "regexp" matching

stveit commented 3 months ago

Scope and purpose

Fixes #297

Original zino seems to use ifalias and ifdescr for planned maintenance matching, while intitial PM implementation used only ifdescr. This PR changes it to use ifalias where applicable instead.

Original zino code confuses me so wouldn't be a bad idea for someone else to take a look and see if this PR actually makes the correct changes

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is. More information about contributing to Zino can be found in the README.

[x] Added a changelog fragment for towncrier
[X] Added/amended tests for new/changed code
[ ] Added/changed documentation
[X] Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
[X] The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
[ ] If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

github-actions[bot] commented 3 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Elapsed time
✅ PYTHON	black	5	0.65s
✅ PYTHON	isort	5	0.21s
✅ PYTHON	ruff	5	0.01s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by _

github-actions[bot] commented 3 months ago

Test results

3 files 3 suites 1m 17s :stopwatch: 550 tests 550 :white_check_mark: 0 :zzz: 0 :x: 1 626 runs 1 624 :white_check_mark: 2 :zzz: 0 :x:

Results for commit a966ba4b.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.20%. Comparing base (a9a85fb) to head (a966ba4). Report is 52 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #340 +/- ## ======================================= Coverage 98.20% 98.20% ======================================= Files 64 64 Lines 7926 7930 +4 ======================================= + Hits 7783 7787 +4 Misses 143 143 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.