Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
4 stars 5 forks source link

Use enums for match types #341

Closed stveit closed 3 months ago

stveit commented 3 months ago

Scope and purpose

Uses existing enum for different matching type instead of comparing against strings with exact same values as the enums. Does not change any functionality, just clears up the code

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is. More information about contributing to Zino can be found in the README.

github-actions[bot] commented 3 months ago

πŸ¦™ MegaLinter status: βœ… SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
βœ… PYTHON black 100 0 1.81s
βœ… PYTHON isort 100 0 0.34s
βœ… PYTHON ruff 100 0 0.03s

See detailed report in MegaLinter reports

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 3 months ago

Test results

β€‡β€ˆβ€‡β€‡3 filesβ€„β€ƒβ€‡β€ˆβ€‡β€‡3 suites   1m 17s :stopwatch: β€‡β€ˆ555 testsβ€ƒβ€‡β€ˆ555 :white_check_mark: 0 :zzz: 0 :x: 1β€ˆ617 runsβ€Šβ€ƒ1β€ˆ615 :white_check_mark: 2 :zzz: 0 :x:

Results for commit 1218d52c.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.20%. Comparing base (41a87dc) to head (1218d52). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #341 +/- ## ======================================= Coverage 98.19% 98.20% ======================================= Files 64 64 Lines 7922 7926 +4 ======================================= + Hits 7779 7783 +4 Misses 143 143 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud