Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
4 stars 5 forks source link

Log warning if secrets file is readable by other users #342

Closed johannaengland closed 3 months ago

johannaengland commented 3 months ago

Scope and purpose

Fixes #280. I did not add an test that it actually logs the warning, but I manually tested it and added tests for the utils function.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is. More information about contributing to Zino can be found in the README.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.57%. Comparing base (168286a) to head (1ba3a5b). Report is 1 commits behind head on master.

Files Patch % Lines
src/zino/zino.py 62.50% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #342 +/- ## ========================================== - Coverage 98.60% 98.57% -0.03% ========================================== Files 77 77 Lines 9688 9701 +13 ========================================== + Hits 9552 9562 +10 - Misses 136 139 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud