Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
4 stars 5 forks source link

Fix wrong match_expression value #343

Closed stveit closed 3 months ago

stveit commented 3 months ago

Scope and purpose

This PR fixes an error in a fixture where match_expression for the fixture is set to port descr, but should be device name instead. It doesnt really matter much since the code that actually does matching is mocked in this instance, but why not just fix it

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is. More information about contributing to Zino can be found in the README.

github-actions[bot] commented 3 months ago

πŸ¦™ MegaLinter status: βœ… SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
βœ… PYTHON black 1 0 0.48s
βœ… PYTHON isort 1 0 0.26s
βœ… PYTHON ruff 1 0 0.01s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

github-actions[bot] commented 3 months ago

Test results

β€‡β€ˆβ€‡β€‡3 filesβ€„β€ƒβ€‡β€ˆβ€‡β€‡3 suites   1m 17s :stopwatch: β€‡β€ˆ555 testsβ€ƒβ€‡β€ˆ555 :white_check_mark: 0 :zzz: 0 :x: 1β€ˆ617 runsβ€Šβ€ƒ1β€ˆ615 :white_check_mark: 2 :zzz: 0 :x:

Results for commit 2b9a4a2c.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.20%. Comparing base (41a87dc) to head (88079d0). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #343 +/- ## ======================================= Coverage 98.19% 98.20% ======================================= Files 64 64 Lines 7922 7926 +4 ======================================= + Hits 7779 7783 +4 Misses 143 143 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud