Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
4 stars 5 forks source link

Rename/alias BGP and Juniper alarm event attributes #352

Closed johannaengland closed 3 months ago

johannaengland commented 3 months ago

Scope and purpose

Work towards #338. Also mentioned in #331.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is. More information about contributing to Zino can be found in the README.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.60%. Comparing base (f9fd3fc) to head (e4843d1). Report is 17 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #352 +/- ## ======================================= Coverage 98.60% 98.60% ======================================= Files 77 77 Lines 9687 9688 +1 ======================================= + Hits 9551 9552 +1 Misses 136 136 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

johannaengland commented 3 months ago

Nice initiative, but I would like a team discussion about these renames before we move ahead...

I agree! I was thinking I could kick-start such a discussion using this PR :grin: