Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
4 stars 5 forks source link

Move `populate_by_name` to `Event` model #357

Closed johannaengland closed 2 months ago

johannaengland commented 3 months ago

Scope and purpose

Inspired by a meeting about Pydantic aliases today. That way not every model using aliases needs to explicitly declare it.

Reference to what populate_by_name does: https://docs.pydantic.dev/latest/api/config/#pydantic.config.ConfigDict.populate_by_name

Related to #338, #335 and #352.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is. More information about contributing to Zino can be found in the README.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.57%. Comparing base (419305a) to head (99d266a). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #357 +/- ## ========================================== - Coverage 98.57% 98.57% -0.00% ========================================== Files 77 77 Lines 9701 9699 -2 ========================================== - Hits 9562 9560 -2 Misses 139 139 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.