Uninett / zino

Zino 2.0 - Network state monitor for research networks
Apache License 2.0
4 stars 5 forks source link

Suppress initial interface down alarms with config option #367

Closed johannaengland closed 2 months ago

johannaengland commented 2 months ago

Scope and purpose

Closes #257.

This is how I interpreted this issue: We have a config option that if it is set to true the first time a PortStateEvent would be created with the interface down state nothing happens instead.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is. More information about contributing to Zino can be found in the README.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.66%. Comparing base (e2164d5) to head (1409037). Report is 9 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #367 +/- ## ======================================= Coverage 98.66% 98.66% ======================================= Files 77 77 Lines 9706 9711 +5 ======================================= + Hits 9576 9581 +5 Misses 130 130 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

johannaengland commented 2 months ago

Settings this to draft/blocked until we get more concrete specification on how this should work