Uninett / zinolib

Python library for zino
Apache License 2.0
1 stars 3 forks source link

Refactor zinolib config parsing #22

Closed hmpf closed 11 months ago

hmpf commented 1 year ago

Closes #11 as a bonus.

The normalize-function fixes a bug (placement of globals) in parse_tcl_config and is in preparation for the new stuff.

I would especially like feedback on the tests/file handling in the tests.

github-actions[bot] commented 1 year ago

Test results

0 tests   0 :heavy_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit f140df82.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 year ago

Codecov Report

Merging #22 (9d586d4) into main (d344a10) will increase coverage by 3.48%. Report is 7 commits behind head on main. The diff coverage is 93.42%.

:exclamation: Current head 9d586d4 differs from pull request most recent head f140df8. Consider uploading reports for the commit f140df8 to get more accurate results

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   67.63%   71.12%   +3.48%     
==========================================
  Files           9       13       +4     
  Lines        1029     1136     +107     
==========================================
+ Hits          696      808     +112     
+ Misses        333      328       -5     
Files Coverage Δ
src/zinolib/config/models.py 100.00% <100.00%> (ø)
src/zinolib/config/toml.py 100.00% <100.00%> (ø)
src/zinolib/controllers/base.py 96.77% <100.00%> (ø)
src/zinolib/controllers/zino1.py 70.86% <100.00%> (+0.19%) :arrow_up:
src/zinolib/event_types.py 99.41% <100.00%> (ø)
src/zinolib/ritz.py 57.63% <100.00%> (+1.44%) :arrow_up:
src/zinolib/config/tcl.py 97.82% <97.82%> (ø)
src/zinolib/config/utils.py 95.23% <95.23%> (ø)
src/zinolib/compat.py 76.47% <66.66%> (-12.42%) :arrow_down:
src/zinolib/config/zino1.py 81.48% <81.48%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

hmpf commented 11 months ago

Joy. They run locally of course. They run on github actions too, what fails is only the last step.

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

hmpf commented 11 months ago

They run on github action stoo, what fails is only the last step.