Uninett / zinolib

Python library for zino
Apache License 2.0
1 stars 3 forks source link

Set "unknown" bfd_addr to None #38

Closed hmpf closed 7 months ago

hmpf commented 7 months ago

Closes #37

github-actions[bot] commented 7 months ago

Test results

    3 files      3 suites   41s :stopwatch:   62 tests   62 :heavy_check_mark: 0 :zzz: 0 :x: 186 runs  186 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit e334474c.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (f066d26) 71.51% compared to head (e334474) 71.92%. Report is 9 commits behind head on main.

Files Patch % Lines
src/zinolib/controllers/zino1.py 60.00% 14 Missing :warning:
src/zinolib/ritz.py 27.77% 13 Missing :warning:
src/zinolib/config/zino1.py 57.89% 8 Missing :warning:
src/zinolib/event_types.py 82.35% 3 Missing :warning:
src/zinolib/utils.py 94.44% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #38 +/- ## ========================================== + Coverage 71.51% 71.92% +0.41% ========================================== Files 13 13 Lines 1271 1343 +72 ========================================== + Hits 909 966 +57 - Misses 362 377 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hmpf commented 7 months ago

I rewrote it to use the decorator from #40 instead of manually adding information to any exception in create. Then there's no need to change any tests.

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication