Uninett / zinolib

Python library for zino
Apache License 2.0
1 stars 3 forks source link

Add server poll #53

Closed hmpf closed 3 months ago

hmpf commented 3 months ago

Old code used the term poll in two different ways:

  1. To ask the server to check for changes to a specific event
  2. To get changes to any event, via ntie

No. 1 was not implemented in the zino1 manager and got to keep its name. No. 2 was renamed to "get_event_update" (it only gets one update at a time, if any are available.)

Two bonuses: the UpdateHandler is better documented and there is now only one way to remove an event from the events list.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 71.01%. Comparing base (d97de03) to head (d4142f4). Report is 7 commits behind head on main.

Files Patch % Lines
src/zinolib/controllers/zino1.py 50.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #53 +/- ## ========================================== - Coverage 71.52% 71.01% -0.51% ========================================== Files 13 13 Lines 1366 1380 +14 ========================================== + Hits 977 980 +3 - Misses 389 400 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Test results

    3 files      3 suites   41s :stopwatch:   63 tests   63 :heavy_check_mark: 0 :zzz: 0 :x: 189 runs  189 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit d4142f4d.

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

hmpf commented 3 months ago

Closes #49, #23