search

Uninett / zinolib

Python library for zino
Apache License 2.0
1 stars 3 forks source link

Raise SocketError on UpdateHandler socket trouble #58

Closed hmpf closed 4 months ago

github-actions[bot] commented 4 months ago

Test results

    3 files      3 suites   41s :stopwatch:   63 tests   63 :heavy_check_mark: 0 :zzz: 0 :x: 189 runs  189 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit e6e6e3e5.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 70.68%. Comparing base (d97de03) to head (a92d7cb). Report is 8 commits behind head on main.

:exclamation: Current head a92d7cb differs from pull request most recent head e6e6e3e

Please upload reports for the commit e6e6e3e to get more accurate results.

Files Patch % Lines
src/zinolib/controllers/zino1.py 40.00% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #58 +/- ## ========================================== - Coverage 71.52% 70.68% -0.84% ========================================== Files 13 13 Lines 1366 1402 +36 ========================================== + Hits 977 991 +14 - Misses 389 411 +22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

podliashanyk commented 4 months ago

Reasoning behind this PR is an issue discovered while working on https://github.com/Uninett/Howitz/pull/87:

action needed with UpdateHandler on logout? IRL discussion with @hmpf concludes: no action needed. UpdateHandler depends on session which is already handled properly on login/logout. On Zino1EventManager.disconnect the UpdateHandler stops working which is expected. UPD: extra check whether socket is OK on recurrent login is needed due to how Zino 1 server handles connections. Per now socket is -1 on recurrent login, meaning something is wrong without detailing what specifically is wrong. Ref https://github.com/Uninett/zinolib/pull/58