UnionInternationalCheminsdeFer / OSDM

Projects related to an open sales & distribution API for public transportation.
https://osdm.io
Apache License 2.0
53 stars 21 forks source link

Booking state model - end states for deleted and expired bookingParts #533

Closed rolandkla closed 3 months ago

rolandkla commented 4 months ago

The booking state model defines the Staes of the individual bookingParts.

There are 2 cases where a bookingPart state does not transition from PREBOOKED:

In both cases, the bookingParts status will remain PEBOOKED, meaning that PREBOOKED is the initial state, but also an end state. This can cause confusion because it is unclear if the bookingPart can still be confirmed or not but the state itself.

I suggest to transition the bookingPart state from PREBOOKED to CANCELLED when the part has not been confirmed, fulfilled or placed on hold. Similar to the expiration of the on hold.

rolandkla commented 4 months ago

Outcome of discussion:

--> @rolandkla to update the PUML and PNG

rolandkla commented 3 months ago

PR https://github.com/UnionInternationalCheminsdeFer/OSDM/tree/feature/533

schlpbch commented 3 months ago

Issue has been fixed.