CGantert345
commented
2 years ago Many thanks, i will clean that part for the next version
Best regards Clemens
Von: Martin Chovanec @.> Gesendet: Mittwoch, 18. Mai 2022 14:48 An: UnionInternationalCheminsdeFer/UIC-barcode @.> Cc: Clemens Gantert @.>; Mention @.> Betreff: Re: [UnionInternationalCheminsdeFer/UIC-barcode] extending the valid until to 500 days (PR #48)
@CGantert345https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FCGantert345&data=05%7C01%7Cclemens.gantert%40deutschebahn.com%7C4f0b76d1423d416ddf7e08da38cc973e%7Ca1a72d9c49e64f6d9af65aafa1183bfd%7C0%7C0%7C637884748611292145%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JzaeBB1U9Hgj7pOXyUQXG4hEB2JycgDzM2DhKfLFOEU%3D&reserved=0 Hi, I see a lot of hardcoded values in the annotations like this:
@IntRange(minValue=0,maxValue=500)I haven't tried it personally, but I've found a post suggesting a way how to avoid this by using a static final variable. Have you considered something like that? https://localcoder.org/get-rid-of-the-value-for-annotation-attribute-must-be-a-constant-expression-mehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flocalcoder.org%2Fget-rid-of-the-value-for-annotation-attribute-must-be-a-constant-expression-me&data=05%7C01%7Cclemens.gantert%40deutschebahn.com%7C4f0b76d1423d416ddf7e08da38cc973e%7Ca1a72d9c49e64f6d9af65aafa1183bfd%7C0%7C0%7C637884748611292145%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EpftgqthqPpwSnjjXOaxSbmyLfl1eO9n3%2BXxCxAicRo%3D&reserved=0
- Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FUnionInternationalCheminsdeFer%2FUIC-barcode%2Fpull%2F48%23issuecomment-1129962939&data=05%7C01%7Cclemens.gantert%40deutschebahn.com%7C4f0b76d1423d416ddf7e08da38cc973e%7Ca1a72d9c49e64f6d9af65aafa1183bfd%7C0%7C0%7C637884748611292145%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=huo%2F2iLG179XxXfx7qaO5wrDCsuyFLQUy0RozmcLuZU%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANS4YNNYIAH72XKQDJD3YJLVKTRGTANCNFSM5WIIQ4RA&data=05%7C01%7Cclemens.gantert%40deutschebahn.com%7C4f0b76d1423d416ddf7e08da38cc973e%7Ca1a72d9c49e64f6d9af65aafa1183bfd%7C0%7C0%7C637884748611292145%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JFZBgXCAUUN3BE8Gk0Gpy%2BlUIWTs7ykQXUyfbEEq328%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>
Pflichtangaben anzeigenhttp://www.deutschebahn.com/pflichtangaben/20220512
N?here Informationen zur Datenverarbeitung im DB-Konzern finden Sie hier: http://www.deutschebahn.com/de/konzern/datenschutz
@CGantert345 Hi, I see a lot of hardcoded values in the annotations like this:
I haven't tried it personally, but I've found a post suggesting a way how to avoid this by using a static final variable. Have you considered something like that? https://localcoder.org/get-rid-of-the-value-for-annotation-attribute-must-be-a-constant-expression-me