UnionInternationalCheminsdeFer / UIC-barcode

implementation of the FCB barcode (IRS 90918-9)
Other
28 stars 8 forks source link

Inflating issue with Steiermark Tickets #58

Closed andrewko closed 1 year ago

andrewko commented 1 year ago

Hi,

we have a problem with validating a 'Steiermark Ticket'. The example ticket is in the following ZIP file: Steiermark Ticket.zip

The inflate loop in StaticFrame.java stucks in an endless loop.

inflater.finished() never returns true

According to an very old bug it is also recommended to check the return value of inflater.inflate(). Recommended solution would look like:

while (!inflater.finished()) { int count = inflater.inflate(inflatedDataBuffer,0,2000); if (inflater.needsDictionary() || count == 0) { break; }

Thanks in advance,

Andrej

dstrobelOEBB commented 1 year ago

Hi Clemens, just to make sure. This is an issue coming from ÖBB side :) Thanks for looking into it. Daniel

CGantert345 commented 1 year ago

the recommended change is added to the master.

Would you need a release of the binary imediately? Otherwise i would wait for the SSB branch to be completed.

andrewko commented 1 year ago

No, we don't need the binary immediately.

CGantert345 commented 1 year ago

released in version 1.4.0