search

UnionOfRAD / lithium

li₃ is the fast, flexible and most RAD development framework for PHP
http://li3.me
BSD 3-Clause "New" or "Revised" License
1.22k stars 238 forks source link

PHP 7.3 compact() E_NOTICE #1342

Closed ericcholis closed 5 years ago

ericcholis commented 5 years ago

In php 7.3, compat now throws an E_NOTICE when passing a variable that isn't set: From the docs:

compact() now issues an E_NOTICE level error if a given string refers to an unset variable. Formerly, such strings have been silently skipped.

I'm having a hard time detecting this with PHPCompatibility checks. Seems like there is an open PHPCompatibility issue that details the difficulty a bit more.

I'll take a crack at cleaning this up as it comes up.

mariuswilms commented 5 years ago

Hey I've begun working on PHP 7.3 compat for the upcoming 1.2 release in https://github.com/UnionOfRAD/lithium/tree/support-php-7.3

Currently some extract command test cases are failing, I didn't yet look at the integration tests.

PHP 7.3 is generally not yet supported, but I hope to do so. If you'd like to help, please check out the branch and fix the remaining test fails.

ericcholis commented 5 years ago

Thanks @mariuswilms. While not fully supported, I've been running lithium under 7.3 on local dev via docker for some weeks now with very little issues. The roadmap to 7.3 might not be much of a challenge.

mariuswilms commented 5 years ago

Yes, you're right. I just implemented support for 7.3 in 1.2.