search

UnionOfRAD / lithium

li₃ is the fast, flexible and most RAD development framework for PHP
http://li3.me
BSD 3-Clause "New" or "Revised" License
1.22k stars 237 forks source link

Update maximum PHP dependency in composer.json #1372

Closed adamroyle closed 7 months ago

adamroyle commented 7 months ago

Can you please tag a 2.0.1 release?

nateabele commented 7 months ago

Yeah, I'd just like to get some sort of automated verification in place for this stuff before pushing any more releases. Do you happen to know of any decent GHA templates for this off-hand?

adamroyle commented 7 months ago

Maybe something like this?

https://github.com/ElephantIO/elephant.io/blob/master/.github/workflows/continuous-integration.yml

I’m not sure about the dependencies required to run the lithium test suite as I had issues getting it to run locally.

nateabele commented 7 months ago

https://github.com/ElephantIO/elephant.io/blob/master/.github/workflows/continuous-integration.yml

Yeah that looks about right, thanks. I'll give it a try tomorrow or Monday.

I’m not sure about the dependencies required to run the lithium test suite as I had issues getting it to run locally.

Oh, which ones? Just curious.

adamroyle commented 7 months ago

I think I'm just unfamiliar with the process of running the lithium tests properly. I managed to get the devcontainer running by changing mysql:5 to mysql:8.0 but I'm a little confused how to get the tests running.

nateabele commented 7 months ago

I haven't had time to finish setting up the tests so I'm just gonna ship this. Let me know if you run into any issues (I think we're good re: compatibility though).