Uniswap / interface

🦄 Open source interfaces for the Uniswap protocol
https://app.uniswap.org
GNU General Public License v3.0
4.96k stars 5.03k forks source link

If any call in the multicall fails, all other calls fail #1151

Closed moodysalem closed 3 years ago

moodysalem commented 4 years ago

If any call in the multicall fails, all other calls fail. This can cause many issues in the Uniswap interface. E.g. a bad token on the token list can cause balances not to load for many other tokens.

First complete this PR: https://github.com/makerdao/multicall/pull/7 Then deploy the multicall v2 to all networks Then update the addresses in the Interface Then update how we interact with multicall to use this new multicall v2 never-failing call

JFrankfurt commented 3 years ago

https://github.com/makerdao/multicall/pull/18/files