search

Uniswap / interface

🦄 Open source interfaces for the Uniswap protocol
https://app.uniswap.org
GNU General Public License v3.0
4.93k stars 4.99k forks source link

Bring back expected output #1535

Closed asood123 closed 3 years ago

asood123 commented 3 years ago

Currently showing minimum output.

Bring back expected output for the main number and rework confirm screen.

For example, the negative number in green is confusing.

image

moodysalem commented 3 years ago

that negative number being green is a separate bug

moodysalem commented 3 years ago

that negative number being green is a separate bug

i just addressed it in https://github.com/Uniswap/uniswap-interface/commit/27094c87f28bed497edc3f7838833e8209a4e945

asood123 commented 3 years ago

Why is the difference so large for such a small trade?

moodysalem commented 3 years ago

Why is the difference so large for such a small trade?

in the screenshot it's a multihop bc arbitrage and the fees added up. we definitely shouldnt prefer multihop for this trade size but thats separate and already documented in the routing bug