search

Uniswap / interface

🦄 Open source interfaces for the Uniswap protocol
https://app.uniswap.org
GNU General Public License v3.0
4.96k stars 5.02k forks source link

Standardize proposal numbers 1-9 #2866

Open willhennessy opened 2 years ago

willhennessy commented 2 years ago

/vote/ page now counts proposals as

where the major version corresponds to the governor contract version: alpha1, alpha2, bravo

Now that the Governor Bravo has stabilized we should normalize proposal numbers as 1, 2, 3,... 9. This can be done by hard coding the proposal numbers.

moodysalem commented 2 years ago

i don't think this is a good idea, it makes it even more confusing that /<bravo address>/1 would point to proposal 9, and also breaks old urls pointing to /<bravo address>/9

willhennessy commented 2 years ago

Should we do away with the // URL pattern then? ideally the URL would simply be /proposal/1

I think the short-term transition cost is worth paying up front at this early stage, so that future users be a more clear experience

Problem statement: people are starting to talk about Uniswap proposal numbers like UNI9 (getty tweet https://twitter.com/getty_hill/status/1458593882921443335). Other interfaces like Tally use this notation too. It will be more clear if we align and abstract the contract details away from the user

On Mon, Nov 29, 2021 at 2:35 PM Moody Salem @.***> wrote:

i don't think this is a good idea, it makes it even more confusing that /<bravo address>/1 would point to proposal 9, and also breaks old urls pointing to //9

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Uniswap/interface/issues/2866#issuecomment-981951495, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJT5WL7GSW6MEWAVMW2VEDUOPIYHANCNFSM5I75NUWA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.