Uniswap / interface

🦄 Open source interfaces for the Uniswap protocol
https://app.uniswap.org
GNU General Public License v3.0
4.87k stars 4.94k forks source link

Cipher Browser not working #565

Closed PaulRBerg closed 4 years ago

PaulRBerg commented 4 years ago

Bug Description Cannot log in with the Cipher Browser.

Steps to Reproduce

  1. Install Cipher Browser on iOS
  2. Open uniswap.exchange.
  3. Tap "Connect to a Wallet" and see no option to log in via the Injected connector

Expected Behavior Should be able to log in.

Additional Context Here's a screenshot taken on an iPhone XR running iOS 12.3.1

IMG_6941

NoahZinsmeister commented 4 years ago

Cipher was acquired by Coinbase last year, and it seems like they're not actively developing the app anymore. The reason it doesn't work is because they're still using window.web3 instead of window.ethereum. I'm inclined to simply consider the app as officially deprecated.

PaulRBerg commented 4 years ago

Okay. I'll close this for now, if anyone from Coinbase/ Cipher wants the wallet working with Uniswap/ Sablier, they should switch to window.ethereum. Thanks for confirming.