Uniswap / interface

đŸ¦„ Open source interfaces for the Uniswap protocol
https://app.uniswap.org
GNU General Public License v3.0
4.9k stars 4.98k forks source link

WalletConnect V2 the address doesn't change according to the network #6771

Open MaksHladun opened 1 year ago

MaksHladun commented 1 year ago

Bug Description When you connect via walletconnect v2 and change the network, the wallet address does not change, chain 1 is always displayed. Although balances and tokens are requested for the selected network, but with the wrong wallet address

Steps to Reproduce

  1. You connect the wallet through walletconnect v2, you can even through the official test wallethttps://react-wallet.walletconnect.com/walletconnect.

https://github.com/Uniswap/interface/assets/91897479/a36ba0c9-7efa-4c0d-b561-fe8f90d52b41

  1. Đ¡hange the network in dapp.
  2. See that the wallet address does not change according to the network.

Expected Behavior The wallet address should vary depending on the selected network

luanccp commented 1 year ago

+1

I am facing the same issue

JFrankfurt commented 1 year ago

I am not familiar with the pattern you're describing. I would always expect the address to remain the same as networks change. (Since the key pair is valid on all networks.)

What wallet are you using and how is it configured?

amiryadid-fb commented 1 year ago

Also experiencing this problem. @JFrankfurt on Fireblocks wallet the address for your Mainnet Eth is always different from your Testnet address.

Besides, WalletConnectV2 allows you to supply an address for each chain separately, I expect that if I supply different addresses they are not ignored by the dapp.

vivekkumar15 commented 11 months ago

We are facing the same issue, wallets can have different addresses on different EVM networks, and changing chains should update the address and assets. It requires an additional page refresh on Uniswap after changing the chain to show the correct address and assets.