search

Uniswap / interface

🦄 Open source interfaces for the Uniswap protocol
https://app.uniswap.org
GNU General Public License v3.0
4.9k stars 4.98k forks source link

Improve "Approve & confirm" flow #960

Closed callil closed 3 years ago

callil commented 4 years ago

Right now a few people get stuck when swapping token -> ETH because they don't notice there are two buttons. We should add a simple progress bar underneath the buttons to help them notice there are two actions.

Screen Shot 2020-07-15 at 11 44 50 AM

A better approach would be to attempt to use metatx and do a true approve&confirm in one transaction. It would be pretty nice if this were possible, especially if there was a way to avoid approving the max amnt of tokens to swap on each address and just doing it up to some reasonable limit based on the tx they are trying to execute.

moodysalem commented 3 years ago

This is covered by https://github.com/Uniswap/uniswap-interface/issues/1072