search

Uniswap / org-v1

🌐 Uniswap protocol homepage
GNU General Public License v3.0
146 stars 226 forks source link

Dead link to pair-addresses explanation #132

Closed luziusmeisser closed 4 years ago

luziusmeisser commented 4 years ago

The page https://uniswap.org/docs/v2/SDK/pair/ mentions a method "getAddress" that does not exist in the Pair contract and links to https://uniswap.org/docs/v2/technical-considerations/pair-addresses, which does not exist either.

Probably, this section should better refer to the pairFor function from https://github.com/Uniswap/uniswap-v2-periphery/blob/master/contracts/libraries/UniswapV2Library.sol and maybe link to https://docs.openzeppelin.com/cli/2.8/deploying-with-create2 for those who want to know what CREATE2 does.

ebonetti commented 4 years ago

From webarchive seems it never existed in the first place. Maybe a target within uniswap docs could be https://uniswap.org/docs/v2/smart-contract-integration/getting-pair-addresses/ .

Actually there are more references to this non existent technical-consideration subfolder, which then turn into broken links in the docs.

callil commented 4 years ago

I think I cleaned these up in the latest. Let me know if you find more issues.