IPFS etag missing - Githubissues

Uniswap / org-v1

🌐 Uniswap protocol homepage

GNU General Public License v3.0

146 stars 227 forks source link

IPFS etag missing #230

Open JustinDrake opened 3 years ago

JustinDrake commented 3 years ago

This blog post highlights that the IPFS hash should be reflected in the etag header field.

I can't find this etag field on my browser. Is the IPFS hash still returned by the Cloudflare gateway? (If not it may be worth updating the blog post.)

Screenshot 2020-12-22 at 20 00 30

moodysalem commented 3 years ago

Indeed it is no longer being sent from Cloudflare since that blog post

Cloudflare provides a way to verify what the gateway serves via an extension described here under the section "Verifying what the Gateway Serves": https://blog.cloudflare.com/e2e-integrity/ Here is that extension, which appears to be Firefox only at the moment. https://github.com/cloudflare/ipfs-ext

JustinDrake commented 3 years ago

it is no longer being sent from Cloudflare since that blog post

Gotcha.

https://github.com/cloudflare/ipfs-ext

Oh, interesting :)

moodysalem commented 3 years ago

I think the proper fix here is to update the uniswap-org docs