search

Uniswap / org-v1

🌐 Uniswap protocol homepage
GNU General Public License v3.0
145 stars 230 forks source link

Javascript SDK quickstart doesn't tell about peerDependencies #268

Open tennox opened 3 years ago

tennox commented 3 years ago

The JS SDK quickstart says only install, but:

warning " > @uniswap/sdk@3.0.3" has unmet peer dependency "@ethersproject/address@^5.0.0-beta".
warning " > @uniswap/sdk@3.0.3" has unmet peer dependency "@ethersproject/contracts@^5.0.0-beta".
warning " > @uniswap/sdk@3.0.3" has unmet peer dependency "@ethersproject/networks@^5.0.0-beta".
warning " > @uniswap/sdk@3.0.3" has unmet peer dependency "@ethersproject/providers@^5.0.0-beta".
warning " > @uniswap/sdk@3.0.3" has unmet peer dependency "@ethersproject/solidity@^5.0.0-beta".

The other docs page tells what this is about.

moodysalem commented 3 years ago

The docs are slightly outdated, you should prefer @uniswap/v2-sdk which actually uses dependencies instead of peer dependencies