search

Uniswap / permit2

🔑🔑🔑 next generation token approvals mechanism
MIT License
759 stars 187 forks source link

`PermitSignature` util cannot be used because of `Permit2` import #206

Closed PaulRBerg closed 1 year ago

PaulRBerg commented 1 year ago

Permit2 uses a frozen Solidity version in its pragma, i.e. 0.8.17:

https://github.com/Uniswap/permit2/blob/bbbc92f895049ca45c4b25a450f9d3e907659284/src/Permit2.sol#L2

This contract is imported in the PermitSignature util:

https://github.com/Uniswap/permit2/blob/bbbc92f895049ca45c4b25a450f9d3e907659284/test/utils/PermitSignature.sol#L7

This in turn means that nobody can use this utility contract unless they are using Solidity v0.8.17, too:

Error (5333): Source file requires different compiler version (current compiler is 0.8.19+commit.7dd6d404.Darwin.appleclang) - note that nightly builds are considered to be strictly less than the released version
 --> lib/permit2/src/Permit2.sol:2:1:
  |
2 | pragma solidity 0.8.17;
PaulRBerg commented 1 year ago

Closed via https://github.com/Uniswap/permit2/pull/215.