search

Uniswap / sdk-core

⚙️ Code shared across TypeScript Uniswap SDK versions
MIT License
121 stars 355 forks source link

circular dependency between `Currency`, `BaseCurrency` and `NativeCurrency` #12

Open justindomingue opened 3 years ago

justindomingue commented 3 years ago

Currency -> Native Currency -> Base Currency -> Currency

marktoda commented 2 years ago

Hey @justindomingue - thanks for reporting this, nice catch! On quick glance, it seems an easy solution would be to have BaseCurrency remove its dependency on Currency by just updating equals(..) to be equals(other: BaseCurrency) instead of equals(other: Currency), I think. Feel free to submit a PR to address it!

ef3n9r98 commented 1 year ago

Hey @marktoda,

Have you found a developer for this yet?

If not, I’ll add it to our site and then find a dev for you.

You wouldn’t have to fund a bounty until someone wants to fix it.

Your bounty is locked in a smart contract until you merge the dev’s PR. That releases it automatically.

Let me know if you have a budget and I’ll add it to our site.

ashutosh887 commented 1 year ago

I would like to work on this @ef3n9r98 @justindomingue