Fixed bug that returned an empty swap router 02 address for base chain

Uniswap / sdk-core

⚙️ Code shared across TypeScript Uniswap SDK versions

MIT License

121 stars 355 forks source link

Fixed bug that returned an empty swap router 02 address for base chain #120

Closed dallinlarsen closed 8 months ago

dallinlarsen commented 9 months ago

I was recieiving an error: Error: resolver or addr is not configured for ENS name (argument="name", value="", code=INVALID_ARGUMENT, version=contracts/5.7.0) and tracked it down to this bug. It seems that calling includes() on the array works but chainId in SUPPORTED_CHAINS doesn't.

jsy1218 commented 8 months ago

@dallinlarsen This is helpful. It probably explains the regression in https://github.com/Uniswap/smart-order-router/pull/481. I will give a try in my local, and see if it passes.

jsy1218 commented 8 months ago

FYI tracking purpose, regression was introduced in https://github.com/Uniswap/sdk-core/pull/112

jsy1218 commented 8 months ago

@dallinlarsen FYI I'm going to merge your change directly, because it helps with the issue https://github.com/Uniswap/smart-order-router/pull/481#issuecomment-1932579689. The contribution credit should still be yours.