search

Uniswap / sdk-core

⚙️ Code shared across TypeScript Uniswap SDK versions
MIT License
121 stars 354 forks source link

Add `Rootstock` Network #123

Closed ahsan-javaiid closed 7 months ago

ahsan-javaiid commented 7 months ago

Description

This PR adds support for Rootstock Network in uniswap sdk. Uniswap v3 contracts are deployed on Rootstock.

Uniswap v3 deployed on Rootstock

The addresses can be verified from the proposals here: RFC: https://gov.uniswap.org/t/deploy-uniswap-v3-on-rootstock-bitcoin-sidechain/22466 Rootstock Vote https://www.tally.xyz/gov/uniswap/proposal/56?chart=2

ChainID: 30 Rootstock RPC: https://public-node.rsk.co

Deployed Contracts v3CoreFactory 0xaF37EC98A00FD63689CF3060BF3B6784E00caD82 nftDescriptor 0xA231609CF5ee20b3FF9bd8bBfD1928737E6e6264 nonfungibleTokenPositionDescriptor 0x1519ab9C0bF7C8f261aCa6c58d59A152C95B3Ebc nonfungibleTokenPositionManager 0x9d9386c042F194B460Ec424a1e57ACDE25f5C4b1 v3Migrator 0x16678977CA4ec3DAD5efc7b15780295FE5f56162 Multicall2 0x996a9858cDfa45Ad68E47c9A30a7201E29c6a386 proxyAdmin 0xE6c623e32eD33f29b4D7C002C01DebDA629e4604 tickLens 0x55B9dF5bF68ADe972191a91980459f48ecA16afC ​​descriptorProxy 0x2AECbeE0dc58e3419A52EEaF6Ea16C498BAeE24F v3Staker 0x96481062BfAA29AdaaeBfC5FA6F46d9556F0150c quoterV2 0xb51727c996C68E60F598A923a5006853cd2fEB31 swapRouter02 0x0B14ff67f0014046b4b99057Aec4509640b3947A Permit2 0xFcf5986450E4A014fFE7ad4Ae24921B589D039b5 Universal Router 0x244f68e77357f86a8522323eBF80b5FC2F814d3E Message Sender 0xf5F4496219F31CDCBa6130B5402873624585615a Message Receiver 0x38aE7De6f9c51e17f49cF5730DD5F2d29fa20758

More About Rootstock

Website: https://rootstock.io/ Dev portal: https://rootstock.io/develop/ Explorer: https://explorer.rsk.co/ | https://rootstock.blockscout.com/ TVL: https://defillama.com/chain/RSK Marketcap: https://coinmarketcap.com/currencies/rsk-infrastructure-framework/

Please consider the pull request i am working on Rootstock addition into uniswap interface. Merging this PR will help to move forward.

Let me know if anything needs to be changed i will promptly fix and reply. Many thanks Uniswap team 🙏 cc: @jsy1218 @zzmp @hensha256

ahsan-javaiid commented 7 months ago

@JackShort @@jsy1218 Would be great if you can review this pull request. I am working on Rootstock addition into Uniswap interface. Merging this PR will help to move forward. Many Thanks! 🙏

jsy1218 commented 7 months ago

@ahsan-javaiid I approved, but I didn't double check the deploy addresses. I trust you got them right :)

jsy1218 commented 7 months ago

@ahsan-javaiid you can ignore lint failure and let us know if you can merge the PR.

ahsan-javaiid commented 7 months ago

@ahsan-javaiid you can ignore lint failure and let us know if you can merge the PR.

@jsy1218 Thank you so much for reviewing the pull request. Yes. I double checked the addresses are correct.

I do not have merge permission in the repo so i would request for the merge.

jsy1218 commented 7 months ago

@ahsan-javaiid do you also need Rootstock network to be routable? If so, you need to add another PR like https://github.com/Uniswap/smart-order-router/pull/501

ahsan-javaiid commented 7 months ago

@ahsan-javaiid do you also need Rootstock network to be routable? If so, you need to add another PR like Uniswap/smart-order-router#501

Yes. Thanks for the reference PR. I am working on it and get back with PR soon! Thanks a lot 🙏 for the consideration.