search

Uniswap / sdk-core

⚙️ Code shared across TypeScript Uniswap SDK versions
MIT License
121 stars 355 forks source link

rename WETH9 to WETH #6

Closed justindomingue closed 3 years ago

moodysalem commented 3 years ago

maybe we can remove these hard coded WETH9 addresses from the sdk, and have Ether take a WETH address and construct the WETH token on the fly in wrapped

justindomingue commented 3 years ago

maybe we can remove these hard coded WETH9 addresses from the sdk, and have Ether take a WETH address and construct the WETH token on the fly in wrapped

aren't we just moving the burden to the clients then? I could maybe just renamed WETH9 at runtime in the interface instead?

moodysalem commented 3 years ago

aren't we just moving the burden to the clients then? I could maybe just renamed WETH9 at runtime in the interface instead?

yes, but it already is on the burden if they want to connect to a diff network. or we should add the optimism/arbitrum + opt/arb testnet tokens