circular dependency between Currency, BaseCurrency and NativeCurrency…

Uniswap / sdk-core

⚙️ Code shared across TypeScript Uniswap SDK versions

MIT License

121 stars 354 forks source link

Closed hiroshitashir closed 1 year ago

hiroshitashir commented 1 year ago

… #12

Removed a cicular dependency by changing equals(other: Currency) to equals(other: BaseCurrency) per comment at https://github.com/Uniswap/sdk-core/issues/12#issuecomment-1176801759

hiroshitashir commented 1 year ago

npm run test passed on sdk-core and v3-sdk with this change.

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.