search

Uniswap / sdk-core

⚙️ Code shared across TypeScript Uniswap SDK versions
MIT License
121 stars 355 forks source link

Add Rootstock `chainId` #78

Closed ahsan-javaiid closed 9 months ago

ahsan-javaiid commented 1 year ago

Description

This PR adds Rootstock chain id to this core sdk as integration proposal for Rootstock with Uniswap is under review.

Reason

To continue with rootstock integration in other Uniswap repos the chainId needs to be supported by sdk-core.

Any Questions

Feel free to ask any questions regarding the consideration of this pull request.

ahsan-javaiid commented 1 year ago

cc: @alepc253

stale[bot] commented 1 year ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

alepc253 commented 1 year ago

Yes, this is still relevant

stale[bot] commented 11 months ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

alepc253 commented 11 months ago

Yes, it is (and it should be quite easy to review and merge).

stale[bot] commented 9 months ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

alepc253 commented 9 months ago

Yes, still waiting for review and merge