search

Uniswap / sdk-core

⚙️ Code shared across TypeScript Uniswap SDK versions
MIT License
121 stars 355 forks source link

Quoter vs QuoterV2 address #82

Open Florian-S-A-W opened 1 year ago

Florian-S-A-W commented 1 year ago

I noticed that the Addresses for the Quoter point to different contracts on different networks. This also happens in the Docs.

For Celo the address points to the QuoterV2 Contract. For default chains e.g. Mainnet the address points to the Quoter Contract.

I would like to access the QuoterV2 Contract address from the v3-sdk. I would suggest adding both addresses in the sdk-core ChainAddresses as optionals.

Florian-S-A-W commented 1 year ago

@just-toby

Florian-S-A-W commented 1 year ago

The QuoterV2 actually seems to be deployed on all supported chains while Quoter is only deployed on the default chains. So maybe let's make quoterAddress optional and add quoterV2Address as non-optional.