feat(v3/v4-sdk): add Permit building

marktoda commented 4 days ago

This commit adds helper functions for building the domains, types, values of permits for v3 and v4 NFTs

PR Scope

Please title your PR according to the following types and scopes following conventional commits:

fix(SDK name): will trigger a patch version
chore(<type>): will not trigger any release and should be used for internal repo changes
<type>(public): will trigger a patch version for non-code changes (e.g. README changes)
feat(SDK name): will trigger a minor version
feat(breaking): will trigger a major version for a breaking change

Description

[Summary of the change, motivation, and context]

How Has This Been Tested?

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]

marktoda commented 4 days ago

at some point potentially worth adding a generic eip712 object like

export type EIP712<V> {
   domain: TypedDataDomain;
   types: Record<..>;
   values: V
}

but doesn't seem worth it now and the incremental multi sdk pr is gonna be annoying

graphite-app[bot] commented 4 days ago

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (09/30/24)

1 reviewer was added and 1 assignee was added to this PR based on 's automation.

marktoda commented 4 days ago

oh definitely! Feel free to add those and I'll review!

Uniswap / sdks