search

Uniswap / sdks

prototype SDK monorepo
38 stars 49 forks source link

Factory address constant should be updated to a chain: address map #57

Open JFrankfurt opened 3 months ago

JFrankfurt commented 3 months ago

FACTORY_ADDRESS should be an AddressMap like WETH9 instead of a string constant that's invalid on some networks. 0x1F98431c8aD98523631AE4a59f267346ea31F984 is not deployed on Base and there have been some transactions to this address assuming it existed: https://basescan.org/address/0x1F98431c8aD98523631AE4a59f267346ea31F984

JFrankfurt commented 3 months ago

@zhongeric do me a solid bruh

hensha256 commented 3 months ago

@JFrankfurt i think you should be using V3_CORE_FACTORY_ADDRESSES instead! FACTORY_ADDRESS should probably be deprecated to signal that. @jsy1218 is that right?

jsy1218 commented 3 months ago

That's right. We should mark v3 FACTORY_ADDRESS as deprecated.

jsy1218 commented 3 months ago

@JFrankfurt @hensha256 addressed in https://github.com/Uniswap/sdks/pull/58