Uniswap / smart-order-router

GNU General Public License v3.0
408 stars 404 forks source link

feat: support zora #584

Closed jsy1218 closed 4 months ago

jsy1218 commented 4 months ago
jsy1218 commented 4 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

graphite-app[bot] commented 4 months ago

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (05/21/24)

3 reviewers were added and 1 assignee was added to this PR based on 's automation.

jsy1218 commented 4 months ago

Have we tested?

~So I know the WETH/USDzC V3 pool liquidity is inefficient for routing, so I asked Zora folk to help add more liquidities~

I mispoke. Turns out there's a liquid WETH/USDcZ v3 pool.

I tested in my local, and they all passed https://app.warp.dev/block/79q8d7nUzP6uekUqRcCNLE. We will need to update SOR repo to include JSON_RPC_PROVIDER_ZORA secret, but can wait until @mikeki is back.

socket-security[bot] commented 4 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@uniswap/permit2-sdk@1.2.1 environment +1 176 kB uniswap-labs-service-account
npm/@uniswap/router-sdk@1.9.2 environment Transitive: network +32 3.62 MB uniswap-labs-service-account
npm/@uniswap/universal-router-sdk@2.1.0 None +13 1.17 MB
npm/@uniswap/v2-sdk@4.3.2 environment +20 1.39 MB uniswap-labs-service-account
npm/@uniswap/v3-sdk@3.11.2 environment Transitive: network +36 5.15 MB uniswap-labs-service-account

🚮 Removed packages: npm/@uniswap/permit2-sdk@1.2.0, npm/@uniswap/router-sdk@1.9.0, npm/@uniswap/universal-router-sdk@1.8.2, npm/@uniswap/v2-sdk@4.3.0, npm/@uniswap/v3-sdk@3.11.0

View full report↗︎