fix: check decimal diffs <= 0 and avoid throwing unchecked exceptions in gas diff token at all

Uniswap / smart-order-router

GNU General Public License v3.0

384 stars 387 forks source link

Closed jsy1218 closed 3 weeks ago

jsy1218 commented 3 weeks ago

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix
What is the current behavior? (You can also link to an open issue here) Even using DAI we can see runtime error.
What is the new behavior (if this is a feature change)? We don't know why, and it shouldn't happen, because DAI and zksync ETH are both 18 decimals. But we will hotfix by checking decimaldiff <=0 so it cannot throw.
Other information:

jsy1218 commented 3 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite

graphite-app[bot] commented 3 weeks ago

1 assignee was added and 4 reviewers were added to this PR based on 's automation.

jsy1218 commented 3 weeks ago

abandoned after discussing with @zhongeric