Closed jsy1218 closed 1 week ago
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @jsy1218 and the rest of your teammates on Graphite
1 assignee was added and 4 reviewers were added to this PR based on 's automation.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug fix
What is the current behavior? (You can also link to an open issue here) In case of simulated onchain revert from tenderly, e.g.:
This results in the https://github.com/Uniswap/smart-order-router/blob/e4cd7f90609b394c5b1e304f10e58438e18dcc50/src/providers/tenderly-simulation-provider.ts#L784 getting
NaN
. In comparison, it shows as gas from both tenderly API and tenderly node reported as different as of now:But in reality, tenderly API also reverted but also returned gas used in the reverted transaction, meanwhile tenderly node doesn't return the gas used in the reverted transaction![Screenshot 2024-06-26 at 4.43.53 PM.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/BB54fKe6Y10GvrrdKXQN/4a5f48fb-5001-44df-978b-eb8fe8e37555.png)
I tested with local SOR CLI, that will make the swap transaction fail with onchain revert: https://app.warp.dev/block/V7gAajjltmHonCGbxpLAp7. Now it shows both tenderly API and tenderly node are matching
TenderlyNodeGasEstimateBundleMatch