Uniswap / smart-order-router

GNU General Public License v3.0
384 stars 387 forks source link

fix: tenderly node simulation block with (block number - 1) #629

Closed jsy1218 closed 1 week ago

jsy1218 commented 1 week ago

Yes, on the API, if you specify bn 100, we take the state of bn 99 and create a new block 100 where we simulate at the beginning. On the Node, if you specify bn 100, we take the state of block 100, and create a fake block 101 where we simulate.

So I'd recommend adding the following changes to check if the diffs remain:

  • add the block_number parameter to all sims in the API bundle
  • use block_number - 1 for the Node bundle
jsy1218 commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

graphite-app[bot] commented 1 week ago

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (07/01/24)

4 reviewers were added and 1 assignee was added to this PR based on 's automation.