Closed samisbakedham closed 2 years ago
Update?
Update?
Hey @samisbakedham - sorry for delay was on holiday. Taking a look now. Thanks for adding these
I see untitled
for proposal titles - any idea whats going on there?
I see
untitled
for proposal titles - any idea whats going on there?
Hey, it could be just test proposals but our team will take a look. Thank you for bringing this up!
@l0c4t0r is attempting to deploy a commit to the Uniswap Team on Vercel.
A member of the Team first needs to authorize it.
I see
untitled
for proposal titles - any idea whats going on there?
Hi, this is because the description field in our test proposals was not formatted according to the "norm". It seems like to common practice is to indicate the proposal title with "# Proposal Title \n\n proposal description..."
In future proposals we will conform to this standard.
I see
untitled
for proposal titles - any idea whats going on there?Hi, this is because the description field in our test proposals was not formatted according to the "norm". It seems like to common practice is to indicate the proposal title with "# Proposal Title \n\n proposal description..."
In future proposals we will conform to this standard.
Yes, this is correct!
Looks good to go!
Merge me
Any Updates? Seems like we're good to go.
Has this been closed? Not seeing the PR anywhere
On Jan 30, 2022, at 11:44 PM, Samuel Safahi @.***> wrote:
Any Updates? Seems like we're good to go.
— Reply to this email directly, view it on GitHub https://github.com/Uniswap/sybil-interface/pull/104#issuecomment-1025377099, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECO4KYAEGJNCIJ2BSLFK23UYYHUVANCNFSM5LLJ7MMQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.
Has this been closed? Not seeing the PR anywhere … On Jan 30, 2022, at 11:44 PM, Samuel Safahi @.***> wrote: Any Updates? Seems like we're good to go. — Reply to this email directly, view it on GitHub <#104 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECO4KYAEGJNCIJ2BSLFK23UYYHUVANCNFSM5LLJ7MMQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you commented.
Still up! Passed all checks too.
Any updates?
Any updates?
Sorry for delay -- still seeing lint errors here though.
Any updates?
Sorry for delay -- still seeing lint errors here though.
I'll check it again and update as needed
Adds support for OpenZeppelin Governance and Adds Candle CNDL Credits To l0c4t0r