search

Uniswap / sybil-interface

Interface that incorporates Sybil, a governance tool for discovering delegates.
https://sybil.org/
GNU General Public License v3.0
70 stars 112 forks source link

feat(governance): add yearn.finance #31

Closed developerfred closed 3 years ago

developerfred commented 3 years ago
vercel[bot] commented 3 years ago

@developerfred is attempting to deploy a commit to the Uniswap Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uniswap/sybil-interface/bfvhdd0vg
✅ Preview: Failed

ianlapham commented 3 years ago

@developerfred Awesome work getting this started - im noticing some issues with request on the yearn subgraph. Is this subgraph public? Happy to help debug but cant see the source.

ianlapham commented 3 years ago

@developerfred Actually it looks like this subgraph has a slightly different schema - if Yearn is an exact fork of Compound it may be better to deploy the same subgraph that tracks Compound and Uniswap governance with the Yearn addresses switched in

developerfred commented 3 years ago

@developerfred Actually it looks like this subgraph has a slightly different schema - if Yearn is an exact fork of Compound it may be better to deploy the same subgraph that tracks Compound and Uniswap governance with the Yearn addresses switched in

@ianlapham Perfect, I will deploy a fork of the subgraph of the compound to the yearn.finance

ianlapham commented 3 years ago

@developerfred I accidently included this history into my latest commit - would you mind making another PR? Sorry about that. One issue im noticing with yearn is that its not a direct fork of compound - so im not sure if the subgraph will work correctly if deployed with the yearn addresses.

There may be a way where we can add an asbtarction layer on top of the data fetching to support different gov types like yearn

developerfred commented 3 years ago

@developerfred I accidently included this history into my latest commit - would you mind making another PR? Sorry about that. One issue im noticing with yearn is that its not a direct fork of compound - so im not sure if the subgraph will work correctly if deployed with the yearn addresses.

There may be a way where we can add an asbtarction layer on top of the data fetching to support different gov types like yearn

No worries, yes I have to think about the best way to do this, there are many protocols that are fork of the yearn. Creating this new way of analyzing a governance that can cover 80% of DeFi

PengFei-Ethereum commented 3 years ago

@developerfred I accidently included this history into my latest commit - would you mind making another PR? Sorry about that. One issue im noticing with yearn is that its not a direct fork of compound - so im not sure if the subgraph will work correctly if deployed with the yearn addresses.

There may be a way where we can add an asbtarction layer on top of the data fetching to support different gov types like yearn

Aave is in a similar situation where the subgraph isn't a direct fork of Compound, and there are key differences with Aave and Compound. I've spoken with a member of the Aave team and they seem to be working on a subgraph for Sybil, but if there is a way to add an abstraction layer on top of the data fetching currently in production, that would help projects like Aave and Yearn maintain their subgraphs and still being able to be implemented into Sybil.