search

Uniswap / universal-router

Uniswap's Universal Router for NFT and ERC20 swapping
GNU General Public License v3.0
410 stars 210 forks source link

DeployScript bug: startBroadcast() in runAndDeployPermit2 is not stopped #248

Closed zeroknots closed 1 year ago

zeroknots commented 1 year ago

When using runAndDeployPermit2() in the deployment script,

  1. permit2 is first deployed and the address written into params. (uses vm.startBroadcast() and does not end it)
  2. run() function is called and UniversalRouter deployed. (starts a new vm.startBroadcast())

This will cause the UniversalRouter deployment to fail.

Very simple fix, but figured I should do a pull request in case other people experience the same issue when integrating the deploy scripts into their build environment.

marktoda commented 1 year ago

closing in favor of https://github.com/Uniswap/universal-router/pull/260 for ci