search

Uniswap / v1-contracts

🐍Uniswap V1 smart contracts
GNU General Public License v3.0
495 stars 318 forks source link

ERC228 support? #1

Closed k06a closed 5 years ago

k06a commented 6 years ago

Are you going to add ERC228 interface support? https://github.com/ethereum/EIPs/issues/228

haydenadams commented 6 years ago

@k06a Not directly in the Vyper smart contracts. change() only represents 1 out of the 12 types of trades on Uniswap, so I would prefer to use the current function names. It also uses uint16 which is supported in Solidity but not Vyper.

I could pretty easily write an ERC228 Solidity contract that makes trades over Uniswap if its desired.