search

Uniswap / v1-contracts

🐍Uniswap V1 smart contracts
GNU General Public License v3.0
495 stars 318 forks source link

Support for latest Vyper compiler #43

Open dmilla opened 4 years ago

dmilla commented 4 years ago

Hello!

First of all congrats for Uniswap, amazing project!

I'm starting a project that will be using Uniswap, and I've updated both contracts so they compile with latest Vyper version. Before creating a PR, I'd like to first confirm if this will be a relevant change for the project, and if yes what other critical parts of the project will need to be updated accordingly besides contracts source?

Thanks!

dmilla commented 4 years ago

I just uploaded code in case someone needs it, you can check related PR #44 .

haydenadams commented 4 years ago

Hey @dmilla thanks for the support!

I appreciate the gesture, but these contracts do not need to be updated, as we are well underway into building Uniswap V2 in Solidity.

I'd rather keep the Vyper code identical to the deployed code of Uniswap V1

dmilla commented 4 years ago

Thanks for your answer, wasn't aware of that, I understand your point @haydenadams !

Out of curiosity, why have you choosed to go back to solidity for Uniswap V2? Where can I follow V2 development?

henry-hz commented 4 years ago

good question, why moving from vyper ?