search

Uniswap / v2-core

🦄 🦄 Core smart contracts of Uniswap V2
https://uniswap.org/docs
GNU General Public License v3.0
2.89k stars 3.11k forks source link

remove misleading comment from pair contract #208

Closed ghost closed 6 months ago

ghost commented 6 months ago

This is a very funny joke, anyone who could read solidity codes can point out this comment is false ( Since totalSupply is already updated by _mintFee function which calls _mint to manipulate totalSupply value, there is no need to cache this thing at all! ).

Maybe we should stop laughing against uniswap forkers who forked the contract with this false comment and remove the code since they are already immutable on explorers.

ghost commented 6 months ago

Looks like someone already pointed out 3 years ago https://twitter.com/AlgorithmicBot/status/1355310629213659144

ghost commented 6 months ago

Think I misunderstood, the comment's purpose is to not define totalSupply before _mintFee function call so I think it suits the purpose so closing the PR.