search

Uniswap / v2-core

🦄 🦄 Core smart contracts of Uniswap V2
https://uniswap.org/docs
GNU General Public License v3.0
2.97k stars 3.18k forks source link

Name all event parameters. #77

Closed MicahZoltu closed 4 years ago

MicahZoltu commented 4 years ago

https://github.com/Uniswap/uniswap-v2-core/blob/816075049f811f1b061bca81d5d040b96f4c07eb/contracts/UniswapV2Factory.sol#L13

The last parameter of this event is missing a name. Either remove the parameter if it is meaningless, or give it a name so integrators know what it is. The missing name also breaks my tooling, which makes me very sad.

NoahZinsmeister commented 4 years ago

the parameter is not meaningless, see https://uniswap.org/docs/v2/smart-contracts/factory/#paircreated, but it's not directly relevant for most people, so we've chosen not to name it. the contracts are frozen, so I'm afraid it's there to stay.