search

Uniswap / v3-core

🦄 🦄 🦄 Core smart contracts of Uniswap v3
https://uniswap.org
Other
4.37k stars 2.68k forks source link

OracleLibrary incompatible with latest OpenZeppelin #545

Open algorithmical opened 2 years ago

algorithmical commented 2 years ago

OpenZepp

pragma solidity ^0.8.0;

incompatible with OracleLibrary which dictates pragma solidity >=0.5.0 <0.8.0;

Related: https://github.com/Uniswap/v3-core/issues/489 Related: https://github.com/Uniswap/v3-core/pull/525

"n this PR I update the pragmas of FullMath and TicketMath to be 0.8.0, as these do not compile with Solidity >=0.8.0. I also think this should be done out of safety, given FullMath relies on overflows and so, as I understand, will behave incorrectly if used with a solidity version >=0.8.0."

When will Uniswap support the latest Solidity version and become again compatible with the popular smart contract framework, Open Zeppelin?

marktoda commented 2 years ago

Hey @algorithmical thanks for your report. We like to keep the main branch synchronized with the deployments on-chain, but have a separate branch for 0.8-compatible code: https://github.com/Uniswap/v3-core/tree/0.8. This branch should be compatible with OZ latest