search

Uniswap / v3-periphery

🦄 🦄 🦄 Peripheral smart contracts for interacting with Uniswap v3
https://uniswap.org
GNU General Public License v2.0
1.17k stars 1.09k forks source link

multicall calls are not isolated, i.e. call 0 affects the results of call 1, ..., N #219

Open moodysalem opened 2 years ago

moodysalem commented 2 years ago

if one call sets x to a value and the next call reads x, then the result of the batch will be dependent on the order in which the calls are executed. the interface assumes all the calls do not modify state and can be safely batched together.

we could revert after each call and put the result in the return data to resolve this