search

Uniswap / v3-periphery

🦄 🦄 🦄 Peripheral smart contracts for interacting with Uniswap v3
https://uniswap.org
GNU General Public License v2.0
1.17k stars 1.09k forks source link

Synchronize openzeppelin #241

Closed godtaehee closed 2 years ago

godtaehee commented 2 years ago

Hello Uniswap.

I met two errors in your v3-periphery repo.

First

image

The error message said like Error HH404: File @openzeppelin/contracts/token/ERC721/IERC721Metadata.sol, imported from @uniswap/v3-periphery/contracts/interfaces/INonfungiblePositionManager.sol, not found.

IERC721Metadata.sol and IERC721Enumerable.sol in openzeppelin-contracts are not included in this path like @openzeppelin/contracts/token/ERC721 no more, but those are included in @openzeppelin/contracts/interfaces

I found the fact that openzeppelin update some path before 2 months.

So this openzeppelin updating is not applied in v3-periphery repo.

Second

image

This is occured in computeAddress function which is located in @uniswap/v3-periphery/contracts/libraries/PoolAddress.sol

But I wonder that this function can remove in v3-periphery repo

So If this function removing is not right, I will restore this function.

Result

I think that first issue must apply in this repo, but second issue is not

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.