search

Uniswap / v3-periphery

🦄 🦄 🦄 Peripheral smart contracts for interacting with Uniswap v3
https://uniswap.org
GNU General Public License v2.0
1.19k stars 1.12k forks source link

Convert from solc 0.7.6 to 0.8.11 #242

Closed br4e closed 2 years ago

br4e commented 2 years ago

This gets us 90% of the way there. However there are three issues: 1) A couple of OZ files were copied in directly in order to get around multiple declaration issues (hexString defined locally and in OZ) and a couple of uniswap/lib files were copied in directly. 2) INonFungiblePositionManager extending IERC721Enumerable was commented out in order to fix broken dependencies 3) "CompilerError: Stack too deep when compiling inline assembly: Variable pos is 19 slot(s) too deep inside the stack." but I can't figure out where "pos" is, and even if I did, it sounds like a nightmare to fix. It might be possible to fix by converting to abicoder v1 to get rid of some extra stack allocations, but we need to find "pos" first.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.